Dont provide style and FD for getting validator #24

New Issue

mitchell · 2024-06-11T13:29:33Z

mitchell commented

2024-06-11 13:29:33 +00:00

Now you need to provide a style and form data even when you are just building the validator. When we add a context, you would also need to provide that.

This would be solved by reintroducing the Validation builder variant.

Now you need to provide a style and form data even when you are just building the validator. When we add a context, you would also need to provide that. This would be solved by reintroducing the Validation builder variant.

mitchell commented

2024-06-11 17:03:57 +00:00

The context being required is the big problem, as it's going to be mostly render context stuff

mitchell commented

2024-06-12 19:10:11 +00:00

Since we are putting the Validation Builder back in, it might make sense to get rid of the RenderFn

mitchell commented

2024-06-12 20:12:31 +00:00

The problem is, if we pass the context in addition to the builder when building components (which is necessary for dynamic select options) then the context must be present for building the form and the validator.

The other option would be to pass an optional Context, which would just be None when getting the Validator.

The problem is, if we pass the context in addition to the builder when building components (which is necessary for dynamic select options) then the context must be present for building the form and the validator. The other option would be to pass an optional Context, which would just be None when getting the Validator.

mitchell commented

2024-06-12 20:19:02 +00:00

It looks like we can even get rid of the fd field in the builder, since it's passed in in the render fn. Perhaps the same with the style.

It looks like we can even get rid of the `fd` field in the builder, since it's passed in in the render fn. Perhaps the same with the style.

mitchell closed this issue

2024-06-12 21:49:37 +00:00

This repo is archived. You cannot comment on issues.